Bug 31729 – WebInspector: Re-enabling timeline-paint test for GTK+ port

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Eric Ayers]

With this change, the timeline-paint.html test should work on the GTK+ port.  This patch is similar to what was done for the Windows port to enable the layoutTestController.display() method to force a paint.

[Eric Ayers]

Created attachment 43594 [details]
WebInpsector: patch to re-enable inpsector/timeline-paint.html test

To be consistent with the Windows port, maybe we should also call displayWebView in dump().  There is a comment in dump() about that, but it seems to be somewhat obsolete (and in the wrong place)

[Eric Seidel (no email)]

This makes sense to me, but actual GTK hackers should at least see this go by.

[Eric Ayers]

Created attachment 44168 [details]
WebInpsector: patch to re-enable inpsector/timeline-paint.html test

Re-implements the paint using gtk_widget_queue_draw() on just the webView widget instead of the entire window.

[Gustavo Noronha (kov)]

Comment on attachment 44168 [details]
WebInpsector: patch to re-enable inpsector/timeline-paint.html test

Thank you very much for the patch!

[WebKit Commit Bot]

Comment on attachment 44168 [details]
WebInpsector: patch to re-enable inpsector/timeline-paint.html test

Rejecting patch 44168 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/WebKitTools/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558

[Eric Seidel (no email)]

Something really should have caught this earlier, sorry.  bug 32039 is one example.

[Eric Seidel (no email)]

This requires an updated patch if it's going to be landed by the commit-bot.  Otherwise someone can land it by hand after fixing the tab.

[Eric Ayers]

Sorry, I've been busy with the Speed Tracer launch.  I'll submit a new patch soon.

[Eric Ayers]

Created attachment 44607 [details]
Web Inspector: fixes inspector/timeline-paint layout test for GTK+

removes extraneous tab

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44607 [details] without any errors.

[WebKit Commit Bot]

Comment on attachment 44607 [details]
Web Inspector: fixes inspector/timeline-paint layout test for GTK+

Clearing flags on attachment: 44607

Committed r51947: <http://trac.webkit.org/changeset/51947>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.