Bug 31717 - [GTK] DRT release event does not create the state correctly
Summary: [GTK] DRT release event does not create the state correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-20 04:14 PST by Alejandro G. Castro
Modified: 2009-11-20 09:45 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch, adds state info to release events (2.74 KB, patch)
2009-11-20 05:06 PST, Alejandro G. Castro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2009-11-20 04:14:15 PST
The release events we synthesize in the DRT do not consider the state of the mouse, it is more correct to add the same state we add to the motion events. Apparently this is not causing any problem though.
Comment 1 Alejandro G. Castro 2009-11-20 05:06:02 PST
Created attachment 43572 [details]
Proposed patch, adds state info to release events
Comment 2 Xan Lopez 2009-11-20 05:12:16 PST
Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

LGTM.
Comment 3 WebKit Commit Bot 2009-11-20 05:18:01 PST
Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Rejecting patch 43572 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--quiet', '43572']" exit_code: 1
Last 500 characters of output:
ingsequence.py", line 49, in run
    self.test()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 113, in test
    LandingSequence.test(self)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in test
    WebKitScripts.run_webkit_tests(launch_safari=not options.non_interactive, fail_fast=options.non_interactive, quiet=options.quiet, port=port)
NameError: global name 'WebKitScripts' is not defined
Comment 4 Xan Lopez 2009-11-20 09:36:15 PST
Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Let's try again...
Comment 5 WebKit Commit Bot 2009-11-20 09:45:38 PST
Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Clearing flags on attachment: 43572

Committed r51239: <http://trac.webkit.org/changeset/51239>
Comment 6 WebKit Commit Bot 2009-11-20 09:45:42 PST
All reviewed patches have been landed.  Closing bug.