Bug 31715 - [Android] Android port lacks implementation of atomicIncrement and atomicDecrement
Summary: [Android] Android port lacks implementation of atomicIncrement and atomicDecr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-20 03:26 PST by Steve Block
Modified: 2009-11-23 03:30 PST (History)
2 users (show)

See Also:


Attachments
Patch 1 for Bug 31715 (1.80 KB, patch)
2009-11-20 03:59 PST, Steve Block
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-20 03:26:19 PST
The Android port lacks implementation of atomicIncrement and atomicDecrement. See JavaScriptCore/wtf/Threading.h.
Comment 1 Steve Block 2009-11-20 03:59:38 PST
Created attachment 43570 [details]
Patch 1 for Bug 31715
Comment 2 Eric Seidel (no email) 2009-11-21 07:19:13 PST
Comment on attachment 43570 [details]
Patch 1 for Bug 31715

I'm surprised that you don't use < > for the system header include:
 77 #include "cutils/atomic.h"

But otherwise this looks fine.
Comment 3 Steve Block 2009-11-23 03:30:38 PST
> I'm surprised that you don't use < > for the system header include:
>  77 #include "cutils/atomic.h"
Fixed

Submitted as http://trac.webkit.org/changeset/51305