Bug 31712 - [Chromium] Ignore line-height CSS property for PushButton
Summary: [Chromium] Ignore line-height CSS property for PushButton
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Kent Tamura
Depends on:
Reported: 2009-11-20 01:02 PST by Kent Tamura
Modified: 2009-11-27 22:15 PST (History)
2 users (show)

See Also:

Proposed patch (2.44 KB, patch)
2009-11-20 01:14 PST, Kent Tamura
eric: review-
Details | Formatted Diff | Diff
Proposed patch (rev.2) (2.38 KB, patch)
2009-11-23 17:48 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-11-20 01:02:12 PST

LayoutTests/fast/forms/control-restrict-line-height.html checks that the following controls should ignore line-height CSS property, and Chromium/Windows and Chromium/Linux don't ignore it for button and search.
 - <select>
 - <input type=button>
 - <input type=search>

This bug addresses the button case.
Comment 1 Kent Tamura 2009-11-20 01:14:33 PST
Created attachment 43566 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2009-11-21 07:18:09 PST
Comment on attachment 43566 [details]
Proposed patch

Your ChangeLog should document which tests cover this change.  Otherwise this looks fine.
Comment 3 Kent Tamura 2009-11-23 17:48:12 PST
Created attachment 43744 [details]
Proposed patch (rev.2)

* Improved ChangeLog
Comment 4 Kent Tamura 2009-11-23 23:06:37 PST
I forgot to mention that this change didn't break existing LayoutTests.
Comment 5 Eric Seidel (no email) 2009-11-26 21:41:24 PST
Comment on attachment 43744 [details]
Proposed patch (rev.2)

Comment 6 WebKit Commit Bot 2009-11-26 22:00:03 PST
Comment on attachment 43744 [details]
Proposed patch (rev.2)

Clearing flags on attachment: 43744

Committed r51428: <http://trac.webkit.org/changeset/51428>
Comment 7 WebKit Commit Bot 2009-11-26 22:00:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Shinichiro Hamaji 2009-11-27 22:15:23 PST
Committed r51455: <http://trac.webkit.org/changeset/51455>