MultiCommandTool should find Command objects automatically instead of with a manual list This makes it easier to add commands, and it also brings the "name" of the command closer to its implementation (which has been a historical point of confusion).
This is setting the groundwork for making it easy to add "hidden" commands which don't show up in --help by default.
Created attachment 43561 [details] Patch
Comment on attachment 43561 [details] Patch kk
Comment on attachment 43561 [details] Patch Rejecting patch 43561 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--quiet', '43561']" exit_code: 1 Last 500 characters of output: ingsequence.py", line 49, in run self.test() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 113, in test LandingSequence.test(self) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in test WebKitScripts.run_webkit_tests(launch_safari=not options.non_interactive, fail_fast=options.non_interactive, quiet=options.quiet, port=port) NameError: global name 'WebKitScripts' is not defined
I think that my patch and adam's patch secretly conflicted. I'll post a new one tomorrow.
Comment on attachment 43561 [details] Patch Oops. I screwed up the bugzilla-tool. Should be fixed now.
Comment on attachment 43561 [details] Patch Rejecting patch 43561 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--quiet', '43561']" exit_code: 1 Last 500 characters of output: n self.test() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 113, in test LandingSequence.test(self) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in test WebKitLandingScripts.run_webkit_tests(launch_safari=not self._options.non_interactive, fail_fast=self._options.non_interactive, quiet=self._options.quiet, port=self._port) NameError: global name 'WebKitScripts' is not defined
Comment on attachment 43561 [details] Patch Clearing flags on attachment: 43561 Committed r51237: <http://trac.webkit.org/changeset/51237>
All reviewed patches have been landed. Closing bug.