Bug 31705 - Web Inspector: Resync Resources Backend and Frontend
Summary: Web Inspector: Resync Resources Backend and Frontend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 21:21 PST by Joseph Pecoraro
Modified: 2009-11-19 22:18 PST (History)
7 users (show)

See Also:

Attachments
[PATCH] Resync (1.31 KB, patch)
2009-11-19 21:26 PST, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2009-11-19 21:21:50 PST 
Resource.js has the following comment for its "enum" values to keep in sync with the real enums:

  // Keep these in sync with WebCore::InspectorResource::Type

Lost sync a long time ago:
http://trac.webkit.org/changeset/34637/trunk/WebCore/page/InspectorController.cpp

However, this was shadowed by the real bug. The type was used in _mimeTypeIsConsistentWithType and always returned true, and the problem was overlooked.
Comment 1 Joseph Pecoraro 2009-11-19 21:26:17 PST 
Created attachment 43548 [details]
[PATCH] Resync
Comment 2 Joseph Pecoraro 2009-11-19 22:18:18 PST 
Landed in http://trac.webkit.org/changeset/51229
r51229 = 478a626e9493ad34878c2a32025991ffaf9e8b5f