Bug 31688 - Split out command parsing and help printing from BugzillaTool
Summary: Split out command parsing and help printing from BugzillaTool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 14:37 PST by Eric Seidel (no email)
Modified: 2009-11-19 15:38 PST (History)
2 users (show)

See Also:


Attachments
Patch (11.32 KB, patch)
2009-11-19 15:08 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-19 14:37:59 PST
Split out command parsing and help printing from BugzillaTool

Make a new class MultiCommandTool which encapsulates the idea of a tool like git or svn which has semantics like:

tool-name [global options] command-name [command-options]

I don't know that we'll ever make another tool, but splitting this out from BugzillaTool proper will allow us to move it into a module and test it more easily.
Comment 1 Eric Seidel (no email) 2009-11-19 15:08:20 PST
Created attachment 43528 [details]
Patch
Comment 2 Adam Barth 2009-11-19 15:13:36 PST
Comment on attachment 43528 [details]
Patch

Ok.  I don't think this is the last work on this topic, but it's progress.  We should move the abstract class to its own file and add tests.
Comment 3 WebKit Commit Bot 2009-11-19 15:29:06 PST
Comment on attachment 43528 [details]
Patch

Clearing flags on attachment: 43528

Committed r51209: <http://trac.webkit.org/changeset/51209>
Comment 4 WebKit Commit Bot 2009-11-19 15:29:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Seidel (no email) 2009-11-19 15:38:36 PST
Committed r51213: <http://trac.webkit.org/changeset/51213>