Bug 31679 - commit-queue empty queue logs twice
Summary: commit-queue empty queue logs twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 12:38 PST by Eric Seidel (no email)
Modified: 2009-11-19 13:02 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2009-11-19 12:38 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-19 12:38:02 PST 
commit-queue empty queue logs twice

It didn't used to.  We don't need the "0 patches in commit-queue []" log.

Empty queue. Sleeping until 2009-11-19 12:35:37 (5 mins).
0 patches in commit-queue []
Empty queue. Sleeping until 2009-11-19 12:40:40 (5 mins).

Probably should be some refactoring done to WorkQueue to better handle this case for all queues, but that's probably best done when we actually have other queues up and running.
Comment 1 Eric Seidel (no email) 2009-11-19 12:38:38 PST 
Created attachment 43517 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-11-19 12:44:48 PST 
Darin is a machine!  Thanks!
Comment 3 WebKit Commit Bot 2009-11-19 13:02:43 PST 
Comment on attachment 43517 [details]
Patch

Clearing flags on attachment: 43517

Committed r51203: <http://trac.webkit.org/changeset/51203>
Comment 4 WebKit Commit Bot 2009-11-19 13:02:53 PST 
All reviewed patches have been landed.  Closing bug.