RESOLVED FIXED 31668
Remove HAVE(STRING_H) guard from JavaScriptCore 
https://bugs.webkit.org/show_bug.cgi?id=31668
Summary Remove HAVE(STRING_H) guard from JavaScriptCore
Laszlo Gombos
Reported 2009-11-19 07:44:40 PST
HAVE(FLOAT_H) is meant to guard <strting.h> includes. It is not used consistently and it always defined (see JavaScriptCore/config.h), so I do not think this adds any value. I propose to remove it - patch will follow. This guard is not used by WebCore or any other parts of WebKit, this is why the bug report is only written against JavaScriptCore.
Attachments
proposed patch (1.48 KB, patch)
2009-11-19 07:48 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-11-19 07:48:47 PST
Created attachment 43503 [details] proposed patch
Laszlo Gombos
Comment 2 2009-11-19 08:18:35 PST
(In reply to comment #0) > HAVE(FLOAT_H) is meant to guard <strting.h> includes. I meant to say HAVE(STRING_H) is meant to guard <string.h> includes.
WebKit Commit Bot
Comment 3 2009-11-19 12:12:50 PST
Comment on attachment 43503 [details] proposed patch Clearing flags on attachment: 43503 Committed r51199: <http://trac.webkit.org/changeset/51199>
WebKit Commit Bot
Comment 4 2009-11-19 12:12:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.