Bug 31668 - Remove HAVE(STRING_H) guard from JavaScriptCore
Summary: Remove HAVE(STRING_H) guard from JavaScriptCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-19 07:44 PST by Laszlo Gombos
Modified: 2009-11-19 12:12 PST (History)
1 user (show)

See Also:

proposed patch (1.48 KB, patch)
2009-11-19 07:48 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-19 07:44:40 PST
HAVE(FLOAT_H) is meant to guard <strting.h> includes. It is not used consistently and it always defined (see JavaScriptCore/config.h), so I do not think this adds any value. I propose to remove it - patch will follow.

This guard is not used by WebCore or any other parts of WebKit, this is why the bug report is only written against JavaScriptCore.
Comment 1 Laszlo Gombos 2009-11-19 07:48:47 PST
Created attachment 43503 [details]
proposed patch
Comment 2 Laszlo Gombos 2009-11-19 08:18:35 PST
(In reply to comment #0)
> HAVE(FLOAT_H) is meant to guard <strting.h> includes.

I meant to say 

HAVE(STRING_H) is meant to guard <string.h> includes.
Comment 3 WebKit Commit Bot 2009-11-19 12:12:50 PST
Comment on attachment 43503 [details]
proposed patch

Clearing flags on attachment: 43503

Committed r51199: <http://trac.webkit.org/changeset/51199>
Comment 4 WebKit Commit Bot 2009-11-19 12:12:57 PST
All reviewed patches have been landed.  Closing bug.