RESOLVED FIXED316674
[ews-build] Refactor GenerateS3URL build step to call generateS3URL directly instead of via subprocess 
https://bugs.webkit.org/show_bug.cgi?id=316674
Summary [ews-build] Refactor GenerateS3URL build step to call generateS3URL directly ...
Aakash Jain
Reported 2026-06-09 10:02:23 PDT
GenerateS3URL was implemented as a MasterShellCommand that spawned python3 to invoke ../Shared/generate-s3-url, then re-parsed the generated URL out of the subprocess's stdout via a regex log observer. Both halves of that dance are unnecessary: the helper is already a Python module living next to the buildbot master, and the master process already has boto3 loaded. Switch GenerateS3URL to inherit from buildstep.BuildStep and call generate_s3_url.generateS3URL() directly.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2026-06-09 10:02:40 PDT
<rdar://problem/179127972>
Aakash Jain
Comment 2 2026-06-09 10:10:14 PDT
Pull request: https://github.com/WebKit/WebKit/pull/66776
EWS
Comment 3 2026-06-15 03:33:33 PDT
Committed 315213@main (02dbc28ba78a): <https://commits.webkit.org/315213@main> Reviewed commits have been landed. Closing PR #66776 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.