Bug 31662 - Don't run websocket tests when run-webkit-tests --no-http
Summary: Don't run websocket tests when run-webkit-tests --no-http
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 00:11 PST by Fumitoshi Ukai
Modified: 2009-11-19 18:49 PST (History)
0 users

See Also:


Attachments
Ignore websocket tests when --no-http is specified. (821 bytes, patch)
2009-11-19 00:16 PST, Fumitoshi Ukai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-11-19 00:11:30 PST
If run-webkit-tests --no-http, it should also disable websocket tests.

cf. https://bugs.webkit.org/show_bug.cgi?id=31425
file:// documents should not be able to open WebSocket connections
Comment 1 Fumitoshi Ukai 2009-11-19 00:16:11 PST
Created attachment 43491 [details]
Ignore websocket tests when --no-http is specified.
Comment 2 Eric Seidel (no email) 2009-11-19 01:05:37 PST
Comment on attachment 43491 [details]
Ignore websocket tests when --no-http is specified.

LGTM.
Comment 3 Fumitoshi Ukai 2009-11-19 02:42:49 PST
Committed r51180: <http://trac.webkit.org/changeset/51180>
Comment 4 Alexey Proskuryakov 2009-11-19 09:49:30 PST
If we make the http option affect websocket tests (which is not necessarily the right thing to do IMO), then we should update run-webkit-tests help output:

  --[no-]http                     Run (or do not run) http tests (default: run)
Comment 5 Fumitoshi Ukai 2009-11-19 18:49:20 PST
(In reply to comment #4)
> If we make the http option affect websocket tests (which is not necessarily the
> right thing to do IMO), then we should update run-webkit-tests help output:
> 
>   --[no-]http                     Run (or do not run) http tests (default: run)

Sorry. is it ok to update help output only, or better to add new flag for -[no-]websocket, instead of ignoring websocket by --no-http?