Bug 31661 - Remove HAVE(FLOAT_H) guard
Summary: Remove HAVE(FLOAT_H) guard
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-18 22:50 PST by Laszlo Gombos
Modified: 2009-11-19 11:55 PST (History)
2 users (show)

See Also:

proposed patch (4.38 KB, patch)
2009-11-19 06:51 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-18 22:50:28 PST
HAVE(FLOAT_H) is meant to guard <float.h> includes. As of now the number of _unguarded_ <float.h> includes is 13; there is only 2 locations where float.h is guarded.

Based on these numbers it seems clear that neither JavaScriptCore nor WebCore would not build without float.h available.  All build would have to define HAVE(FLOAT_H), which is not the case today - and this sometimes leads to build inconsistencies (e.g. http://trac.webkit.org/changeset/51170).

I would proposed to remove the HAVE(FLOAT_H) - as this seems to be a hard dependency for all WebKit components.

Patch will follow.
Comment 1 Laszlo Gombos 2009-11-19 06:51:46 PST
Created attachment 43498 [details]
proposed patch
Comment 2 WebKit Commit Bot 2009-11-19 11:54:57 PST
Comment on attachment 43498 [details]
proposed patch

Clearing flags on attachment: 43498

Committed r51197: <http://trac.webkit.org/changeset/51197>
Comment 3 WebKit Commit Bot 2009-11-19 11:55:03 PST
All reviewed patches have been landed.  Closing bug.