RESOLVED FIXED 31656
-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes 
https://bugs.webkit.org/show_bug.cgi?id=31656
Summary -webkit-user-drag: element Drag images include overflow decorations from inco...
Oliver Hunt
Reported 2009-11-18 18:22:06 PST
Drag images should not include overflow decorations from nodes that are not children
Attachments
Patch (1.75 KB, patch)
2009-11-18 21:32 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2009-11-19 12:00 PST, Oliver Hunt 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-11-18 21:32:36 PST
Created attachment 43484 [details] Patch
mitz
Comment 2 2009-11-18 22:46:54 PST
Comment on attachment 43484 [details] Patch > + if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground)) { > + if (!paintInfo.paintingRoot || isDescendantOf(paintInfo.paintingRoot)) > + layer()->paintOverflowControls(paintInfo.context, tx, ty, paintInfo.rect); > + } Can’t use use shouldPaintWithinRoot? You are never supposed to be a proper descendant of the painting root. You should just add the test to the first if’s condition instead of nesting like that. It would be good to have a manual test case for this. I don’t think it necessarily has to be checked in, but at least attach it to the bug, if possible, for future reference. r- because I think you don’t need to call isDescendantOf().
Oliver Hunt
Comment 3 2009-11-19 12:00:20 PST
Created attachment 43516 [details] Patch
Dave Hyatt
Comment 4 2009-11-19 12:43:39 PST
Comment on attachment 43516 [details] Patch r=me
Oliver Hunt
Comment 5 2009-11-19 14:05:24 PST
Committed r51205
Note You need to log in before you can comment on or make changes to this bug.