RESOLVED FIXED 31655
Normalize ' and " in bugzilla-tool 
https://bugs.webkit.org/show_bug.cgi?id=31655
Summary Normalize ' and " in bugzilla-tool
Adam Barth
Reported 2009-11-18 17:57:22 PST
Style ftw
Attachments
Patch (29.45 KB, patch)
2009-11-18 17:58 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-11-18 17:58:23 PST
Created attachment 43475 [details] Patch
Eric Seidel (no email)
Comment 2 2009-11-18 18:06:20 PST
Personally I prefer ' over ". Although in either case we should be consistent. We should see if the python style guide has guidance on this issue.
Eric Seidel (no email)
Comment 3 2009-11-18 18:17:05 PST
Adam recommends that we just pick one and go with it. I'm not sure I care enough either way. He suggests that whichever we pick that we pretend the other style doesn't exist at all. Meaning: "foo \"bar\" baz" always instead of some sort of exception to allow 'foo "bar" baz'
Eric Seidel (no email)
Comment 4 2009-11-18 18:18:23 PST
Comment on attachment 43475 [details] Patch LGTM. Sad to see my little ' go, but I'm glad these are consistent.
WebKit Commit Bot
Comment 5 2009-11-18 22:19:10 PST
Comment on attachment 43475 [details] Patch Clearing flags on attachment: 43475 Committed r51176: <http://trac.webkit.org/changeset/51176>
WebKit Commit Bot
Comment 6 2009-11-18 22:19:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.