Bug 31652 - ASSERT thrown when a high value is used for roman numerals in lists
Summary: ASSERT thrown when a high value is used for roman numerals in lists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 16:17 PST by Rahul Kuchhal
Modified: 2009-11-19 12:25 PST (History)
2 users (show)

See Also:

Attachments
potential fix for assert (3.14 KB, patch)
2009-11-18 16:21 PST, Rahul Kuchhal 		eric: review-
Details | Formatted Diff | Diff
patch with updated layout test (2.59 KB, patch)
2009-11-19 08:52 PST, Rahul Kuchhal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rahul Kuchhal 2009-11-18 16:17:25 PST 
WebKit throws ASSERT for this html:
<html> 
<body> 
<ol start="3888" type="i"> 
<li>Foo </li> 
</ol> 
</body> 
</html>

Posting one potential fix and a layout test soon.
Comment 1 Rahul Kuchhal 2009-11-18 16:21:57 PST 
Created attachment 43470 [details]
potential fix for assert
Comment 2 Eric Seidel (no email) 2009-11-19 01:08:02 PST 
Comment on attachment 43470 [details]
potential fix for assert

This should be a dumpAsText() test since it is just testing for a crash.

The test should say something like:

PASS: this test did not crash, bug 31652

for the output.
Comment 3 Rahul Kuchhal 2009-11-19 08:52:13 PST 
Created attachment 43507 [details]
patch with updated layout test
Comment 4 WebKit Commit Bot 2009-11-19 12:25:28 PST 
Comment on attachment 43507 [details]
patch with updated layout test

Clearing flags on attachment: 43507

Committed r51201: <http://trac.webkit.org/changeset/51201>
Comment 5 WebKit Commit Bot 2009-11-19 12:25:33 PST 
All reviewed patches have been landed.  Closing bug.