WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31648
[Chromium] Remove dependencies to dummy pthreads headers
https://bugs.webkit.org/show_bug.cgi?id=31648
Summary
[Chromium] Remove dependencies to dummy pthreads headers
Nate Chapin
Reported
2009-11-18 14:52:28 PST
Currently, in order to build JavaScriptCore/wtf/, the Chromium port depends on a couple of dummy headers (pthread.h and sched.h) that live in
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/
. These dependencies are in fact not necessary, as they are located in wtf's tcmalloc files (which Chromium doesn't use). Ergo, update JavaScriptCore.gyp to exclude wtf/TC*, and update WebKit/chromium/DEPS to not include webkit/build/ from chromium's svn repo.
Attachments
patch
(2.96 KB, patch)
2009-11-18 14:57 PST
,
Nate Chapin
fishd
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nate Chapin
Comment 1
2009-11-18 14:57:52 PST
Created
attachment 43465
[details]
patch
Darin Fisher (:fishd, Google)
Comment 2
2009-11-18 15:08:34 PST
Comment on
attachment 43465
[details]
patch
> Index: WebKit/chromium/ChangeLog
...
> + Remove Chromium port's dependency on some dummy pthreads header > + files that live in the Chromium repository.
nit: please add a bug link here
Nate Chapin
Comment 3
2009-11-18 16:00:12 PST
http://trac.webkit.org/changeset/51144
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug