Bug 31648 - [Chromium] Remove dependencies to dummy pthreads headers
Summary: [Chromium] Remove dependencies to dummy pthreads headers
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
Depends on:
Reported: 2009-11-18 14:52 PST by Nate Chapin
Modified: 2009-11-18 16:00 PST (History)
0 users

See Also:

patch (2.96 KB, patch)
2009-11-18 14:57 PST, Nate Chapin
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-11-18 14:52:28 PST
Currently, in order to build JavaScriptCore/wtf/, the Chromium port depends on a couple of dummy headers (pthread.h and sched.h) that live in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/ .   These dependencies are in fact not necessary, as they are located in wtf's tcmalloc files (which Chromium doesn't use).

Ergo, update JavaScriptCore.gyp to exclude wtf/TC*, and update WebKit/chromium/DEPS to not include webkit/build/ from chromium's svn repo.
Comment 1 Nate Chapin 2009-11-18 14:57:52 PST
Created attachment 43465 [details]
Comment 2 Darin Fisher (:fishd, Google) 2009-11-18 15:08:34 PST
Comment on attachment 43465 [details]

> Index: WebKit/chromium/ChangeLog
> +        Remove Chromium port's dependency on some dummy pthreads header
> +        files that live in the Chromium repository.

nit: please add a bug link here
Comment 3 Nate Chapin 2009-11-18 16:00:12 PST