Bug 316450 – REGRESSION (314474@main?): Various webkitpy tests flakily failing

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Ryan Haddad]

https://results.webkit.org/?suite=webkitpy-tests&suite=webkitpy-tests&test=webkitscmpy.test.land_unittest.TestLand.test_with_removed_oops&test=webkitscmpy.test.land_unittest.TestLandGitHub.test_merge_queue

[2963/3278] webkitscmpy.test.land_unittest.TestLand.test_with_removed_oops erred:
  Traceback (most recent call last):
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py", line 119, in test_with_removed_oops
      self.assertEqual(0, program.main(
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 187, in main
      return parsed.main(
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py", line 385, in main
      if args.defaults or Terminal.choose("Delete branch '{}'?".format(source_branch), default='Yes') == 'Yes':
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py", line 88, in choose
      response = cls.input(': ', alert_after=alert_after)
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py", line 50, in input
      return input(*args, **kwargs)
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/terminal.py", line 36, in function
      return args[cls.index - 1]
  IndexError: tuple index out of range

[2965/3278] webkitscmpy.test.land_unittest.TestLandGitHub.test_merge_queue failed:
  Traceback (most recent call last):
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py", line 535, in test_merge_queue
      self.assertEqual(
  AssertionError: Lists differ: ["'y' has no spaces, assuming user intends[603 chars]ed'"] != ['Using committed changes...', 'Detected m[536 chars]ed'"]

  First differing element 0:
  "'y' has no spaces, assuming user intends it to be a branch name"
  'Using committed changes...'

  First list contains 1 additional elements.
  First extra element 14:
  "Adding 'merge-queue' to 'PR 1 | To Be Committed'"

  Diff is 738 characters long. Set self.maxDiff to None to see it.

[Ryan Haddad]

Based on the test history, these failures started at / shortly after https://commits.webkit.org/314474@main landed. It touches webkitcorepy/webkitscmpy, so it seems related.

[Ryan Haddad]

*** This bug has been marked as a duplicate of bug 316264 ***