WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31627
Web Inspector: Store cookie domains in the WebInspector object.
https://bugs.webkit.org/show_bug.cgi?id=31627
Summary
Web Inspector: Store cookie domains in the WebInspector object.
Alexander Pavlov (apavlov)
Reported
2009-11-18 05:47:55 PST
Currently cookie domains are pushed from InspectorController and stored in the Storage panel. Since other clients may need the cookie domain list, it should be stored in the WebInspector object.
Attachments
patch
(7.65 KB, patch)
2009-11-18 08:35 PST
,
Alexander Pavlov (apavlov)
timothy
: review-
Details
Formatted Diff
Diff
patch (fixed)
(7.67 KB, patch)
2009-11-18 09:57 PST
,
Alexander Pavlov (apavlov)
timothy
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
patch (fix mac build)
(7.67 KB, patch)
2009-11-19 03:51 PST
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2009-11-18 08:35:17 PST
Created
attachment 43435
[details]
patch
Timothy Hatcher
Comment 2
2009-11-18 09:26:40 PST
Comment on
attachment 43435
[details]
patch
> + var match = payload.documentURL.match(/^(?:http[s]?|file):\/\/([\/]*[^\/]+)/);
I am curious if this catches the right "domain" for file URLs.
> + if (typeof this.cookieDomains[domain] !== "undefined")
A better way to do this is: if (domain in this.cookieDomains) This change would mean Cookies would not be available if the Resources panel ins't enabled. That seems confusing and limiting. But otherwise I like the clean approch this has over the old code…
Timothy Hatcher
Comment 3
2009-11-18 09:28:34 PST
Comment on
attachment 43435
[details]
patch I'd like to understand how this works when the Resources panel is disabled before it gets r+ed.
Alexander Pavlov (apavlov)
Comment 4
2009-11-18 09:57:34 PST
Created
attachment 43438
[details]
patch (fixed) Fixed the "Local Files" issue and the domain existence check.
WebKit Commit Bot
Comment 5
2009-11-18 14:51:35 PST
Comment on
attachment 43438
[details]
patch (fixed) Rejecting patch 43438 from commit-queue. Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1 Last 500 characters of output: cts/CommitQueue/WebCore/inspector/TimelineRecordFactory.cpp -o /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/TimelineRecordFactory.o ** BUILD FAILED ** The following build commands failed: WebCore: Distributed-CompileC /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/InspectorResource.o /Users/eseidel/Projects/CommitQueue/WebCore/inspector/InspectorResource.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure)
Eric Seidel (no email)
Comment 6
2009-11-18 15:01:47 PST
Sorry to be so slow about getting to the patch. The commit-queue was down for the last 5 days due to
bug 31615
. It's back now. If you post an updated patch which builds properly on mac this will be landed promptly.
Alexander Pavlov (apavlov)
Comment 7
2009-11-19 03:51:49 PST
Created
attachment 43494
[details]
patch (fix mac build)
WebKit Commit Bot
Comment 8
2009-11-19 05:03:19 PST
Comment on
attachment 43494
[details]
patch (fix mac build) Clearing flags on attachment: 43494 Committed
r51182
: <
http://trac.webkit.org/changeset/51182
>
WebKit Commit Bot
Comment 9
2009-11-19 05:03:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug