Currently cookie domains are pushed from InspectorController and stored in the Storage panel. Since other clients may need the cookie domain list, it should be stored in the WebInspector object.
Created attachment 43435 [details] patch
Comment on attachment 43435 [details] patch > + var match = payload.documentURL.match(/^(?:http[s]?|file):\/\/([\/]*[^\/]+)/); I am curious if this catches the right "domain" for file URLs. > + if (typeof this.cookieDomains[domain] !== "undefined") A better way to do this is: if (domain in this.cookieDomains) This change would mean Cookies would not be available if the Resources panel ins't enabled. That seems confusing and limiting. But otherwise I like the clean approch this has over the old code…
Comment on attachment 43435 [details] patch I'd like to understand how this works when the Resources panel is disabled before it gets r+ed.
Created attachment 43438 [details] patch (fixed) Fixed the "Local Files" issue and the domain existence check.
Comment on attachment 43438 [details] patch (fixed) Rejecting patch 43438 from commit-queue. Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1 Last 500 characters of output: cts/CommitQueue/WebCore/inspector/TimelineRecordFactory.cpp -o /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/TimelineRecordFactory.o ** BUILD FAILED ** The following build commands failed: WebCore: Distributed-CompileC /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/InspectorResource.o /Users/eseidel/Projects/CommitQueue/WebCore/inspector/InspectorResource.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure)
Sorry to be so slow about getting to the patch. The commit-queue was down for the last 5 days due to bug 31615. It's back now. If you post an updated patch which builds properly on mac this will be landed promptly.
Created attachment 43494 [details] patch (fix mac build)
Comment on attachment 43494 [details] patch (fix mac build) Clearing flags on attachment: 43494 Committed r51182: <http://trac.webkit.org/changeset/51182>
All reviewed patches have been landed. Closing bug.