Bug 31616 - [Chromium] Some minor cleanup in the Chromium WebKit API
Summary: [Chromium] Some minor cleanup in the Chromium WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-17 22:43 PST by Darin Fisher (:fishd, Google)
Modified: 2009-11-18 13:49 PST (History)
0 users

See Also:

Attachments
v1 patch (3.19 KB, patch)
2009-11-17 22:45 PST, Darin Fisher (:fishd, Google) 		dimich: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-11-17 22:43:26 PST 
[Chromium] Some minor cleanup in the Chromium WebKit API

There are missing WEBKIT_API decorations in WebNode.h and WebFormElement.h,
which are used to annotate methods that should be exported from WebKit.dll.

We should make WebNode::action() be a const method.

We should utilize WebFrameImpl::fromFrame() to simplify code in WebNode::frame().
Comment 1 Darin Fisher (:fishd, Google) 2009-11-17 22:45:36 PST 
Created attachment 43405 [details]
v1 patch
Comment 2 Darin Fisher (:fishd, Google) 2009-11-18 13:49:28 PST 
Landed as http://trac.webkit.org/changeset/51130