Bug 31601 - Move showDebugBorders and showRepaintCounter to Settings/Preferences
Summary: Move showDebugBorders and showRepaintCounter to Settings/Preferences
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Marrin
Depends on:
Reported: 2009-11-17 16:08 PST by Chris Marrin
Modified: 2009-11-18 11:24 PST (History)
0 users

See Also:

Patch (19.76 KB, patch)
2009-11-18 10:24 PST, Chris Marrin
cmarrin: review-
Details | Formatted Diff | Diff
Replacement patch - gets rid of errant printfs (16.97 KB, patch)
2009-11-18 10:31 PST, Chris Marrin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-11-17 16:08:51 PST
Right now these are using Mac specific pref accessors. They need to be moved into the Settings system so they can work on other platforms.
Comment 1 Chris Marrin 2009-11-18 10:24:54 PST
Created attachment 43440 [details]

This adds prefs to WebKit and Settings to WebCore. You now use defaults write with WebKitShowDebugBorders and WebKitShowRepaintCounter. You can do this while WebKit is running. But since WebKit is not that great about reloading prefs, you often need to do the defaults write twice and then turn on and off a Debug flat (like Accelerated Compositing) and finally reload, to get the change to be taken. Adding a Debug menu item to Safari to turn these on and off would fix all this. Until then the best approach is to use defaults write and then restart Safari. This is the same as today, so it shouldn't be a problem.
Comment 2 Chris Marrin 2009-11-18 10:31:56 PST
Created attachment 43442 [details]
Replacement patch - gets rid of errant printfs
Comment 3 Simon Fraser (smfr) 2009-11-18 11:17:39 PST
Comment on attachment 43442 [details]
Replacement patch - gets rid of errant printfs

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 51121)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,38 @@
> +2009-11-18  Chris Marrin  <cmarrin@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
> +        https://bugs.webkit.org/show_bug.cgi?id=31601
> +
> +        These are used to debug accelerated compositing layers

Your changelog should mention stuff about moving them from GraphicsLayerCA to GraphicsLayer, and plumbing them through the backing and compositor.

Comment 4 Chris Marrin 2009-11-18 11:24:01 PST
Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.base.exp
Sending        WebCore/page/FrameView.cpp
Sending        WebCore/page/Settings.cpp
Sending        WebCore/page/Settings.h
Sending        WebCore/platform/graphics/GraphicsLayer.h
Sending        WebCore/platform/graphics/GraphicsLayerClient.h
Sending        WebCore/platform/graphics/mac/GraphicsLayerCA.mm
Sending        WebCore/rendering/RenderLayerBacking.cpp
Sending        WebCore/rendering/RenderLayerBacking.h
Sending        WebCore/rendering/RenderLayerCompositor.cpp
Sending        WebCore/rendering/RenderLayerCompositor.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/WebView/WebPreferenceKeysPrivate.h
Sending        WebKit/mac/WebView/WebPreferences.mm
Sending        WebKit/mac/WebView/WebPreferencesPrivate.h
Sending        WebKit/mac/WebView/WebView.mm
Transmitting file data .................
Committed revision 51122.