Right now these are using Mac specific pref accessors. They need to be moved into the Settings system so they can work on other platforms.
Created attachment 43440 [details] Patch This adds prefs to WebKit and Settings to WebCore. You now use defaults write with WebKitShowDebugBorders and WebKitShowRepaintCounter. You can do this while WebKit is running. But since WebKit is not that great about reloading prefs, you often need to do the defaults write twice and then turn on and off a Debug flat (like Accelerated Compositing) and finally reload, to get the change to be taken. Adding a Debug menu item to Safari to turn these on and off would fix all this. Until then the best approach is to use defaults write and then restart Safari. This is the same as today, so it shouldn't be a problem.
Created attachment 43442 [details] Replacement patch - gets rid of errant printfs
Comment on attachment 43442 [details] Replacement patch - gets rid of errant printfs > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 51121) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,38 @@ > +2009-11-18 Chris Marrin <cmarrin@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter > + https://bugs.webkit.org/show_bug.cgi?id=31601 > + > + These are used to debug accelerated compositing layers Your changelog should mention stuff about moving them from GraphicsLayerCA to GraphicsLayer, and plumbing them through the backing and compositor. r=me
Sending WebCore/ChangeLog Sending WebCore/WebCore.base.exp Sending WebCore/page/FrameView.cpp Sending WebCore/page/Settings.cpp Sending WebCore/page/Settings.h Sending WebCore/platform/graphics/GraphicsLayer.h Sending WebCore/platform/graphics/GraphicsLayerClient.h Sending WebCore/platform/graphics/mac/GraphicsLayerCA.mm Sending WebCore/rendering/RenderLayerBacking.cpp Sending WebCore/rendering/RenderLayerBacking.h Sending WebCore/rendering/RenderLayerCompositor.cpp Sending WebCore/rendering/RenderLayerCompositor.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/WebView/WebPreferenceKeysPrivate.h Sending WebKit/mac/WebView/WebPreferences.mm Sending WebKit/mac/WebView/WebPreferencesPrivate.h Sending WebKit/mac/WebView/WebView.mm Transmitting file data ................. Committed revision 51122.