Bug 31585 - Allow custom memory allocation control for the other part of platform directory in WebCore
Summary: Allow custom memory allocation control for the other part of platform directo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-17 07:02 PST by Zoltan Horvath
Modified: 2009-11-19 01:35 PST (History)
0 users

See Also:

Patch (7.57 KB, patch)
2009-11-17 07:02 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch (7.22 KB, patch)
2009-11-17 07:04 PST, Zoltan Horvath
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-11-17 07:02:19 PST
Created attachment 43362 [details]

Inherits the following classes from FastAllocBase because these are
        instantiated by 'new':

        class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
        class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
        class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
        class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188

        Inherits the following classes from Noncopyable because these are
        instantiated by 'new' and no need to be copyable:

        class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
        class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
        struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71

        class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
        class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
Comment 1 Zoltan Horvath 2009-11-17 07:04:33 PST
Created attachment 43363 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-11-18 13:45:20 PST
Comment on attachment 43363 [details]
proposed patch

I think this all looks fine to me except MediaPlayerPrivateInterface.  MediaPlayerPrivateInterface is an ABC (Abastract Base Class), no?  Does it make sense to mandate that the interface can't be copied?  Maybe?
Comment 3 Zoltan Horvath 2009-11-18 15:23:40 PST
Yes, it is an ABC. It doesn't, but Darin said it'd be better to use Noncopyable where it's possible. This is the reason why I choose Noncopyable for this class.
Comment 4 Zoltan Horvath 2009-11-19 01:35:02 PST
Landed in 51179.