Bug 31585 – Allow custom memory allocation control for the other part of platform directory in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zoltan Horvath]

Created attachment 43362 [details]
Patch

Inherits the following classes from FastAllocBase because these are
        instantiated by 'new':

        class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
        class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
        class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
        class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188

        Inherits the following classes from Noncopyable because these are
        instantiated by 'new' and no need to be copyable:

        class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
        class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
        struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71

        class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
        class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119

[Zoltan Horvath]

Created attachment 43363 [details]
proposed patch

[Eric Seidel (no email)]

Comment on attachment 43363 [details]
proposed patch

I think this all looks fine to me except MediaPlayerPrivateInterface.  MediaPlayerPrivateInterface is an ABC (Abastract Base Class), no?  Does it make sense to mandate that the interface can't be copied?  Maybe?

[Zoltan Horvath]

Yes, it is an ABC. It doesn't, but Darin said it'd be better to use Noncopyable where it's possible. This is the reason why I choose Noncopyable for this class.

[Zoltan Horvath]

Landed in 51179.
http://trac.webkit.org/changeset/51179