Bug 31575 – Fix WebKit build when JAVASCRIPT_DEBUGGER is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

Building QtWebKit with --minimal will result in the following linker error:

WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to `WebCore::JSConsole::profile(JSC::ExecState*, JSC::ArgList const&)'
WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to `WebCore::JSConsole::profileEnd(JSC::ExecState*, JSC::ArgList const&)'

This is probably caused by r50933.

[Mikhail Naganov]

Created attachment 43377 [details]
Proposed fix

I tried to make 'console.profile()' and 'console.profileEnd()' declarations platform-dependent, but for some reason this doesn't work. So I took another route and made their implementations empty in the case when there is no debugger.

Laszlo, can you try your debuggerless Qt build with this patch, please?

[Laszlo Gombos]

I can confirm that the proposed patch builds for JSC + ENABLE_JAVASCRIPT_DEBUGGER=0 case (tested with build-webkit --qt --minimal)

[Dmitry Titov]

> I tried to make 'console.profile()' and 'console.profileEnd()' declarations
> platform-dependent, but for some reason this doesn't work. So I took another
> route and made their implementations empty in the case when there is no
> debugger.

It seems that defined(V8_BINDING) && V8_BINDING is the way used in IDL files to check if the bindings are generated for V8. It might be a cleaner way to do this.

[Mikhail Naganov]

Created attachment 43418 [details]
an easier way

Thanks, Dimich! That's really an easier way, and it works with Chromium.

Laszlo, can I ask you to test this patch, please? If it works for you, I'll find someone to review and submit it.

[Eric Seidel (no email)]

Comment on attachment 43418 [details]
an easier way

I don't understand why the chromium build doesn't define ENABLE_JAVASCRIPT_DEBUGGER.  Probably because ENABLE_JAVASCRIPT_DEBUGGER depends on JSC?  If that's the case then we really should come up with a define for the debugger which would not depend on JSC.

[Eric Seidel (no email)]

(I'm not sure who the JSC debugger expert is these days, but ccing Oliver so that someone in JSC land sees this go by.)

[WebKit Commit Bot]

Comment on attachment 43418 [details]
an easier way

Clearing flags on attachment: 43418

Committed r51153: <http://trac.webkit.org/changeset/51153>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Laszlo Gombos]

Thanks !

[Mikhail Naganov]

(In reply to comment #5)
> (From update of attachment 43418 [details])
> I don't understand why the chromium build doesn't define
> ENABLE_JAVASCRIPT_DEBUGGER.  Probably because ENABLE_JAVASCRIPT_DEBUGGER
> depends on JSC?  If that's the case then we really should come up with a define
> for the debugger which would not depend on JSC.

Yes, currently the code under ENABLE_JAVASCRIPT_DEBUGGER defines is tied directly to JSC, so it won't event compile in Chromium.