Bug 31566 - chrome/mac: cmd-left inserts character instead of going back
Summary: chrome/mac: cmd-left inserts character instead of going back
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-16 14:28 PST by Nico Weber
Modified: 2009-11-17 16:25 PST (History)
1 user (show)

See Also:

Revert 50887 (1.73 KB, patch)
2009-11-16 14:31 PST, Nico Weber
fishd: review+
Details | Formatted Diff | Diff
Add link to bug to changelog. (1.79 KB, patch)
2009-11-17 10:42 PST, Nico Weber
dimich: review+
dimich: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2009-11-16 14:28:20 PST
Some git regressed that.
Comment 1 Nico Weber 2009-11-16 14:31:03 PST
Created attachment 43326 [details]
Revert 50887

This has as consequence that Chrome/mac does not send keypressed() events for keypresses with cmd down. I don't know of any website where this has a negative consequence, but Safari sends keypress() in that case. That's sad, but cmd-left not functioning is even more sad.

I'll file a bug on me to read up on the isSystemKey stuff and see if I can find a patch that makes both behaviors work, but not before there are lots of automated tests for our keyboard handling stuff.
Comment 2 Darin Fisher (:fishd, Google) 2009-11-16 23:00:36 PST
Comment on attachment 43326 [details]
Revert 50887

> Index: WebKit/chromium/ChangeLog
> +        Revert r50887, it regressed handling of cmd-left when a text box is
> +        focused.
> +

nit: Please include a link to this bug report.

otherwise, R=me
Comment 3 Nico Weber 2009-11-17 10:42:54 PST
Created attachment 43369 [details]
Add link to bug to changelog.
Comment 4 Nico Weber 2009-11-17 10:43:20 PST
Done, thanks. Also, the chromium-side bug is http://crbug.com/27844 .
Comment 5 Dmitry Titov 2009-11-17 16:19:50 PST
Comment on attachment 43369 [details]
Add link to bug to changelog.

removing cq+, will land manually
Comment 6 Dmitry Titov 2009-11-17 16:25:10 PST
landed: http://trac.webkit.org/changeset/51095