RESOLVED FIXED 31561
[Chromium] Support null NPObject* parameter in _NPN_SetException 
https://bugs.webkit.org/show_bug.cgi?id=31561
Summary [Chromium] Support null NPObject* parameter in _NPN_SetException
Nate Chapin
Reported 2009-11-16 12:12:49 PST
Currently, if a plugin calls NPN_SetException and passes us a null NPObject*, we would crash. Additionally, if an NPN_SetException is coming from an out of process plugin, it is very likely that the NPObject* is pointing to an object living in the plugin's memory space in the plugin process, rather than in the renderer process where the exception is actually being thrown. This will allow Chromium to just pass in a null NPObject* rather than trying to ferry an object that wouldn't be used anyway between processses.
Attachments
patch (1.27 KB, patch)
2009-11-16 12:15 PST, Nate Chapin 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-11-16 12:15:32 PST
Created attachment 43318 [details] patch
Darin Fisher (:fishd, Google)
Comment 2 2009-11-16 14:07:18 PST
Comment on attachment 43318 [details] patch > Index: WebCore/ChangeLog ... > + Handle the case of a null NPObject* in NPN_SetException in > + the V8 bindings. I had to read the bug summary to understand this patch. It would be good to put more of the justification for this change here in the ChangeLog. Otherwise, R=me
Nate Chapin
Comment 3 2009-11-16 14:41:32 PST
(In reply to comment #2) > (From update of attachment 43318 [details]) > > Index: WebCore/ChangeLog > ... > > + Handle the case of a null NPObject* in NPN_SetException in > > + the V8 bindings. > > I had to read the bug summary to understand this patch. It would be > good to put more of the justification for this change here in the > ChangeLog. > > Otherwise, R=me Done and committed: http://trac.webkit.org/changeset/51054
Note You need to log in before you can comment on or make changes to this bug.