Bug 31560 - [Qt] Failing LayoutTests/editing/deleting/5408255.html
Summary: [Qt] Failing LayoutTests/editing/deleting/5408255.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Chang Shu
Depends on:
Blocks: 5578
  Show dependency treegraph
Reported: 2009-11-16 10:42 PST by Chang Shu
Modified: 2010-03-25 06:46 PDT (History)
2 users (show)

See Also:

fix patch (5.77 KB, patch)
2009-11-16 18:30 PST, Chang Shu
no flags Details | Formatted Diff | Diff
fix patch (1.11 KB, patch)
2010-03-22 11:33 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2009-11-16 10:42:59 PST
Run the following layout test on Qt platform and it fails.

The root cause of the failure is missing deleteButton image support.
Comment 1 Chang Shu 2009-11-16 18:30:52 PST
Created attachment 43336 [details]
fix patch
Comment 2 Eric Seidel (no email) 2009-11-18 15:39:02 PST
Comment on attachment 43336 [details]
fix patch

Comment 3 WebKit Commit Bot 2009-11-18 16:35:12 PST
Comment on attachment 43336 [details]
fix patch

Clearing flags on attachment: 43336

Committed r51154: <http://trac.webkit.org/changeset/51154>
Comment 4 WebKit Commit Bot 2009-11-18 16:35:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Kent Hansen 2010-03-22 09:14:21 PDT
(In reply to comment #1)
> Created an attachment (id=43336) [details]
> fix patch

Since this adds public API, you should add documentation for the DeleteButtonGraphic value. A "\value DeleteButtonGraphic" line under "\enum QWebSettings::WebGraphic" in qwebsettings.cpp, with an appropriate description, is sufficient.
Comment 6 Chang Shu 2010-03-22 11:31:50 PDT
Reopen for adding documentation.
Comment 7 Chang Shu 2010-03-22 11:33:30 PDT
Created attachment 51315 [details]
fix patch

Thanks for the comment, Kent. This patch takes care of the documentation.
Comment 8 Simon Hausmann 2010-03-22 14:42:10 PDT
Comment on attachment 51315 [details]
fix patch

r+, but feel free to elaborate a bit more where this is used. Users will ask: "What's a delete button?"
Comment 9 Chang Shu 2010-03-25 06:45:30 PDT
Manually committed the patch after adding more descriptions as suggested by Simon.
Committed revision 56537.