Bug 315565 – [WPE][GTK] Warn in build-webkit when building Release without assertions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Carlos Alberto Lopez Perez]

Currently the EWS Release bots for GTK and WPE run with -DENABLE_ASSERTS=ON but the post-commit bots and the default builds for developers don't.

This causes issues because:
1) It is confusing for developers to see that their patch causes a assert on the EWS that they can't reproduce because the build config they have is not the same than the EWS
2) It makes our gardening efforts not aligned with the reality of the EWS. So that caused issues when we tried to use a less-forgiving algo for the EWS regarding flakies, see bug 310315 that had to be reverted because there were lot of flakies with asserts enabled that didn't accounted for.


In bug 312811 I proposed as a solution to this to enable asserts by default on DEVELOPER_MODE Release builds: for developers, for post-commit bots and for EWS bots.

But I got internal push back as some developers don't want to build by default with assertions enabled in release (makes webkit slower and more prone to crash).

So the new idea is:


 A) Don't enable asserts by default when building release using build-webkit, but instead print a 1-line warning if asserts are not enabled like this:
   "Building release without assertions. Pass --enable-asserts to match the CI build". So developers are always aware that release tests on the CI run with that.

 B) Enable asserts on all the post-commit bots that run non-performance tests: https://build.webkit.org/#/builders?tags=%2BLinux&tags=%2BTests&tags=%2BRelease&tags=-Perf

 C) Do not enable asserts on the builders that just build alone but don't run tests neither upload their built product to another testers

 D) Switch the GTK perf bot to build its own built-product without assertions instead of relying on the built product of the GTK release default one that will enable assertions: https://github.com/WebKit/WebKit/pull/63263


This bug report is for doing A)
D) is already done and B and C would be done internally on the bots config

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/65678

[EWS]

Committed 313986@main (b5a4cbb2ccc9): <https://commits.webkit.org/313986@main>

Reviewed commits have been landed. Closing PR #65678 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/178068320>