RESOLVED FIXED 31546
bugzilla-tool needs a land-attachment command 
https://bugs.webkit.org/show_bug.cgi?id=31546
Summary bugzilla-tool needs a land-attachment command
Eric Seidel (no email)
Reported 2009-11-16 04:44:45 PST
bugzilla-tool needs a land-attachment command The commit-queue (and some users) really want to be able to land just one attachment off of a bug, instead of all of them at once. Also, land-attachment allows you to land patches which are obsolete, or never got an r+, etc.
Attachments
Patch (4.85 KB, patch)
2009-11-16 04:48 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Fixored (5.45 KB, patch)
2009-11-16 04:54 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Fix the help strings (5.47 KB, patch)
2009-11-16 04:57 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Maintain argument order when landing (6.54 KB, patch)
2009-11-16 05:16 PST, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-16 04:48:24 PST
Created attachment 43294 [details] Patch
Eric Seidel (no email)
Comment 2 2009-11-16 04:54:29 PST
Created attachment 43296 [details] Fixored
Eric Seidel (no email)
Comment 3 2009-11-16 04:57:13 PST
Created attachment 43297 [details] Fix the help strings
Adam Barth
Comment 4 2009-11-16 05:04:26 PST
Comment on attachment 43297 [details] Fix the help strings As we discussed, we want to maintain the order of attachements given on the command line.
Eric Seidel (no email)
Comment 5 2009-11-16 05:16:21 PST
Created attachment 43298 [details] Maintain argument order when landing
Adam Barth
Comment 6 2009-11-16 05:18:42 PST
Comment on attachment 43298 [details] Maintain argument order when landing This seems fine now
Eric Seidel (no email)
Comment 7 2009-11-16 05:25:31 PST
Committed r51033: <http://trac.webkit.org/changeset/51033>
David Kilzer (:ddkilzer)
Comment 8 2009-11-16 06:40:36 PST
(In reply to comment #7) > Committed r51033: <http://trac.webkit.org/changeset/51033> The commit-queue merged the ChangeLog entry in the "middle" of the file instead of at the beginning. Do we have a bug for this?
Eric Seidel (no email)
Comment 9 2009-11-16 14:49:04 PST
Actually, this is bugzilla-tool, and caused by land-diff, not the commit-queue. The commit-queue uses land-patches (and as of this bug, land-attachment), but we've not seen that produce the wrong ChangeLog in a very long time. Since the commit log has been off this weekend, Adam and I have been using land-diff again, and it looks like land-diff is in fact the culprit. I"ll update bug 28092.
Note You need to log in before you can comment on or make changes to this bug.