31546 – bugzilla-tool needs a land-attachment command

Bug 31546 - bugzilla-tool needs a land-attachment command

Summary: bugzilla-tool needs a land-attachment command

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC OS X 10.5

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:	31548
	Show dependency tree / graph

Reported:	2009-11-16 04:44 PST by Eric Seidel (no email)
Modified:	2009-11-16 14:49 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (4.85 KB, patch) 2009-11-16 04:48 PST, Eric Seidel (no email)	no flags	Details \| Formatted Diff \| Diff
Fixored (5.45 KB, patch) 2009-11-16 04:54 PST, Eric Seidel (no email)	no flags	Details \| Formatted Diff \| Diff
Fix the help strings (5.47 KB, patch) 2009-11-16 04:57 PST, Eric Seidel (no email)	no flags	Details \| Formatted Diff \| Diff
Maintain argument order when landing (6.54 KB, patch) 2009-11-16 05:16 PST, Eric Seidel (no email)	abarth: review+	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Seidel (no email) 2009-11-16 04:44:45 PST

bugzilla-tool needs a land-attachment command

The commit-queue (and some users) really want to be able to land just one attachment off of a bug, instead of all of them at once.  Also, land-attachment allows you to land patches which are obsolete, or never got an r+, etc.

Comment 1 Eric Seidel (no email) 2009-11-16 04:48:24 PST

Created attachment 43294 [details]
Patch

Comment 2 Eric Seidel (no email) 2009-11-16 04:54:29 PST

Created attachment 43296 [details]
Fixored

Comment 3 Eric Seidel (no email) 2009-11-16 04:57:13 PST

Created attachment 43297 [details]
Fix the help strings

Comment 4 Adam Barth 2009-11-16 05:04:26 PST

Comment on attachment 43297 [details]
Fix the help strings

As we discussed, we want to maintain the order of attachements given on the command line.

Comment 5 Eric Seidel (no email) 2009-11-16 05:16:21 PST

Created attachment 43298 [details]
Maintain argument order when landing

Comment 6 Adam Barth 2009-11-16 05:18:42 PST

Comment on attachment 43298 [details]
Maintain argument order when landing

This seems fine now

Comment 7 Eric Seidel (no email) 2009-11-16 05:25:31 PST

Committed r51033: <http://trac.webkit.org/changeset/51033>

Comment 8 David Kilzer (:ddkilzer) 2009-11-16 06:40:36 PST

(In reply to comment #7)
> Committed r51033: <http://trac.webkit.org/changeset/51033>

The commit-queue merged the ChangeLog entry in the "middle" of the file instead of at the beginning.  Do we have a bug for this?

Comment 9 Eric Seidel (no email) 2009-11-16 14:49:04 PST

Actually, this is bugzilla-tool, and caused by land-diff, not the commit-queue.  The commit-queue uses land-patches (and as of this bug, land-attachment), but we've not seen that produce the wrong ChangeLog in a very long time.

Since the commit log has been off this weekend, Adam and I have been using land-diff again, and it looks like land-diff is in fact the culprit.  I"ll update bug 28092.