Bug 31544 – Move StyleQueue over to using PatchCollection

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Barth]

That's what infrastructure is for.

[Adam Barth]

Created attachment 43291 [details]
Patch

[Adam Barth]

Created attachment 43292 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 43292 [details]
Patch

I think add_all should be add_patches
add() doens't need to exist.

The tests will need to update names if you do that.

There is likely some super-slick python way to do this, by implementing the right bits to be a sequence type, but that's more python than I know.  I'll CC some python folks though and they can give post-landing comments if they choose.

[Adam Barth]

	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/patchcollection.py
	M	WebKitTools/Scripts/modules/patchcollection_unittest.py
Committed r51030

[Evan Martin]

Not quite sure what you're asking, but if it's about add vs add_all, you can do something like


def add(self, *patches):
  use patches like an array


foobar.add(somepatch)       # works, passes a one-length array
foobar.add(patch1, patch2)  # also works
foobar.add(*patches)        # can also pass arrays


so you'd have stuff like

+    def add_all_from_bug(self, bug_id):
+        self.add_all(self._bugs.fetch_patches_from_bug(bug_id))
instead be
def add_from_bug(self, bug_id):
  self.add(*self._bugs.fetch_patches_from_bug(bug_id))