Bug 31528 - bugzilla-tool needs apply-attachment
Summary: bugzilla-tool needs apply-attachment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-15 22:25 PST by Eric Seidel (no email)
Modified: 2009-11-16 00:40 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.28 KB, patch)
2009-11-16 00:25 PST, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-15 22:25:15 PST 
bugzilla-tool needs land-attachment, apply-attachment, etc.

land-patches and apply-patches are great (they take bug ids)
but sometimes you want to work with attachment ids, even when attachments have been obsoleted, or not even marked as patches!
Comment 1 Eric Seidel (no email) 2009-11-16 00:25:30 PST 
Created attachment 43274 [details]
Patch
Comment 2 Adam Barth 2009-11-16 00:36:58 PST 
Comment on attachment 43274 [details]
Patch

 171         Command.__init__(self, 'Applies an attachment to the local working directory.', 'BUGID', options=options)

bugid?  should be attachmentid
Comment 3 Eric Seidel (no email) 2009-11-16 00:39:40 PST 
Committed r51015: <http://trac.webkit.org/changeset/51015>
Comment 4 Eric Seidel (no email) 2009-11-16 00:40:34 PST 
Actually http://trac.webkit.org/changeset/51016.  bugzilla-tool land-diff gets confused if you have local commits.