Bug 315255 – InspectorIdentifierRegistry.h public header has double-quoted includes that break WebCore module verifier on iOS internal SDK

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Source/WebCore/inspector/InspectorIdentifierRegistry.h has four double-quoted #includes:

    #include "FrameIdentifier.h"
    #include "ProcessIdentifier.h"
    #include "ResourceLoaderIdentifier.h"
    #include "ScriptExecutionContextIdentifier.h"

This is invalid in a framework public header. When WebCore_Private is built against the iOS internal SDK, the WebCore module verifier fails with:

    Double-quoted include "ProcessIdentifier.h" in framework header, expected angle-bracketed instead
    InspectorIdentifierRegistry.h:29
    Error
    Could not build module 'WebCore_Private'
    (... and the same for FrameIdentifier.h:28, ResourceLoaderIdentifier.h:30, ScriptExecutionContextIdentifier.h:31)

The module verifier is currently iOS-only (per Richard Robinson), and Open Source EWS does not run it, so the header has shipped on main with the bad includes since b/310162 created it. Surfaced today via commits.webkit.org/311409@main breaking the iOS internal SDK build.

Fix: change the four lines to <WebCore/X.h> form, sorted with the other angle-bracketed framework includes. Patch ready on eng/bburg/fix-inspector-identifier-registry-public-header-includes; will go up as a PR after iOS device debug build verifies module verifier passes locally.

Reported by Richard Robinson on Slack.

[Radar WebKit Bug Importer]

<rdar://problem/177584900>

[Blaze Burg]

Pull request: https://github.com/WebKit/WebKit/pull/65359

[EWS]

Committed 313634@main (2e2ba4310c12): <https://commits.webkit.org/313634@main>

Reviewed commits have been landed. Closing PR #65359 and removing active labels.