RESOLVED FIXED315248
[CMake] Forward --cmake from run-minibrowser/run-swiftbrowser to underlying perl scripts
https://bugs.webkit.org/show_bug.cgi?id=315248
Summary [CMake] Forward --cmake from run-minibrowser/run-swiftbrowser to underlying p...
zak ridouh
Reported 2026-05-20 17:43:29 PDT
Follow-up to 313522@main, which added --cmake to configuration_options() but didn't thread it through Port.run_minibrowser() / Port.run_swiftbrowser(). As a result, `run-minibrowser --debug --cmake` accepted the flag at the Python layer but never passed it to old-run-minibrowser, so webkitdirs.pm fell back to the Xcode build tree and the launch failed to find the CMake-built MiniBrowser. Append --cmake to the args passed to old-run-minibrowser and run-swiftbrowser-perl-wrapper when the option is set, matching how --<platform> and --<configuration> are already forwarded.
Attachments
Radar WebKit Bug Importer
Comment 1 2026-05-20 17:43:35 PDT
zak ridouh
Comment 2 2026-05-20 17:45:05 PDT
EWS
Comment 3 2026-05-20 19:33:42 PDT
Committed 313629@main (62cd2f059024): <https://commits.webkit.org/313629@main> Reviewed commits have been landed. Closing PR #65352 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.