WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
315200
[WPE][GTK] Rationalize Vulkan types and their base wrapper templates
https://bugs.webkit.org/show_bug.cgi?id=315200
Summary
[WPE][GTK] Rationalize Vulkan types and their base wrapper templates
Adrian Perez
Reported
2026-05-20 08:55:42 PDT
Currently we have the BaseStruct<T> and Structure<T, C> templates defined directly in VulkanTypes.h; but: * Structure<T, C> does not need to inherit from BaseStruct<T>, because in reality Vulkan handles and structures are used differently. Inheritance for convenience of (very little) reuse here is not a good idea because we cannot pass a Structure where a Handle is expected. - While at it, these should be called “Structure” and “Handle”. * Handles may be owned by other objects in some cases (for example VkPhysicalDevice) and instead of making each class override methods is not great. - Instead, we should be defining a different type for a handle that is “borrowed” and owned by some other object. This kind of handle would be copyable. * It would be nicer to have separate VulkanHandle.h / VulkanStructure.h files for these types.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2026-05-20 09:12:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/65296
EWS
Comment 2
2026-05-21 00:04:23 PDT
Committed
313650@main
(f5514504e1ab): <
https://commits.webkit.org/313650@main
> Reviewed commits have been landed. Closing PR #65296 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2026-05-21 00:05:13 PDT
<
rdar://problem/177596999
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug