WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
315067
[CMake] Compile per-test plug-in classes into TestWebKitAPI.wkbundle
https://bugs.webkit.org/show_bug.cgi?id=315067
Summary
[CMake] Compile per-test plug-in classes into TestWebKitAPI.wkbundle
zak ridouh
Reported
2026-05-18 19:37:04 PDT
I added the per-test plug-in classes from the Xcode WebProcessPlugIn target's membershipExceptions list. Five files are dual-membership with TestWebKit; since WEBKIT_COMPUTE_SOURCES marks their originals HEADER_FILE_ONLY, build them here via generated #include shims. Extend the include path with Tests/WebKit/WKWebView and WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR. I also added the missing direct imports to ClearWrappersNavigatePlugIn.mm (<wtf/RetainPtr.h>) and ContentFilteringPlugIn.mm (<WebCore/PlatformExportMacros.h>); both were relying on the prefix-header / BUILDING_TestWebKit config path that the bundle target doesn't go through.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-05-18 19:37:11 PDT
<
rdar://problem/177396182
>
zak ridouh
Comment 2
2026-05-18 20:21:40 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/65157
EWS
Comment 3
2026-05-19 14:05:58 PDT
Committed
313519@main
(e3b3680f8792): <
https://commits.webkit.org/313519@main
> Reviewed commits have been landed. Closing PR #65157 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug