WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
315050
[CMake][Mac] mac-tsan: set USE_SYSTEM_MALLOC=ON and guard TSan bindir against uninstrumented reconfigure
https://bugs.webkit.org/show_bug.cgi?id=315050
Summary
[CMake][Mac] mac-tsan: set USE_SYSTEM_MALLOC=ON and guard TSan bindir against...
Simon Lewis
Reported
2026-05-18 14:41:20 PDT
Two fixes for the mac-tsan preset: 1. Set USE_SYSTEM_MALLOC=ON. e05f64d91da made bmalloc force BUSE_SYSTEM_MALLOC=1 under __has_feature(thread_sanitizer) (BPlatform.h), so BUSE_TZONE=0. But WTF's PlatformUse.h has no matching TSan branch, so USE_TZONE_MALLOC stays 1, and TZoneMalloc.h #errors "TZones enabled in WTF, but not enabled in bmalloc". Setting USE_SYSTEM_MALLOC at the preset level keeps WTF and bmalloc in agreement. 2. Extend the OptionsMac.cmake bindir-name guard to TSan. When a ninja-triggered RERUN_CMAKE wipes CMakeCache.txt, the reconfigure runs without --preset and silently produces an uninstrumented build. The ASan tree already FATAL_ERRORs on this; do the same for TSan.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-05-18 14:41:25 PDT
<
rdar://problem/177376705
>
EWS
Comment 2
2026-05-19 08:42:12 PDT
Committed
313486@main
(6acf180f923e): <
https://commits.webkit.org/313486@main
> Reviewed commits have been landed. Closing PR #65135 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug