Bug 31505 – [GTK] Tab key does not cycle through elements by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This seems to be caused by caused by r50642 ( http://trac.webkit.org/changeset/50642 ).

[Martin Robinson]

Created attachment 43222 [details]
Patch for this issue

This problem seems to be the result of a bad merge. I've attached a patch correcting the merge and extending the original insert-tab test to cover this case.

[Gustavo Noronha (kov)]

Comment on attachment 43222 [details]
Patch for this issue

> +        el.focus();
> +        if (window.eventSender) {
> +            eventSender.keyDown("\t");
> +        }

Braces.

>          if (window.layoutTestController) {
>              layoutTestController.dumpAsText();
> -            // Set this preference so the tab key will actually insert a tab character- like in Mail.
> +        }

More braces? =)

> +        if (window.layoutTestController) {
>              layoutTestController.setTabKeyCyclesThroughElements(false);
>          }

Ditto. There are some others.

Can you split the test from the translatable strings/param flags?

[Martin Robinson]

Created attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

Thanks for the review. I'm attaching corrected patches now.

[Martin Robinson]

Created attachment 43375 [details]
Properly localize tab-key-cycles-through-elements documentation strings

[Martin Robinson]

Created attachment 43378 [details]
Properly localize documentation strings (with Changelog)

Forgot the Changelog on the last patch; attaching a corrected patch now.

[Gustavo Noronha (kov)]

Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

looks good

[Gustavo Noronha (kov)]

Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)

This one as well.

[Gustavo Noronha (kov)]

Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

I will land manually, since the bot is down.

[Gustavo Noronha (kov)]

Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)

I will land manually, since the bot is down.

[Gustavo Noronha (kov)]

Landed as r51108, and r51109.