31505 – [GTK] Tab key does not cycle through elements by default

Bug 31505 - [GTK] Tab key does not cycle through elements by default

Summary: [GTK] Tab key does not cycle through elements by default

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKitGTK (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Linux

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2009-11-13 21:29 PST by Martin Robinson
Modified:	2009-11-18 05:21 PST (History)
CC List:	1 user (show)

See Also:

Attachments
Patch for this issue (5.18 KB, patch) 2009-11-13 22:35 PST, Martin Robinson	gustavo: review-	Details \| Formatted Diff \| Diff
Ensure that tab-key-cycles-through-elements is true by default (4.76 KB, patch) 2009-11-17 11:57 PST, Martin Robinson	gustavo: review+ gustavo: commit-queue-	Details \| Formatted Diff \| Diff
Properly localize tab-key-cycles-through-elements documentation strings (1.45 KB, patch) 2009-11-17 11:57 PST, Martin Robinson	no flags	Details \| Formatted Diff \| Diff
Properly localize documentation strings (with Changelog) (2.34 KB, patch) 2009-11-17 12:43 PST, Martin Robinson	gustavo: review+ gustavo: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Robinson 2009-11-13 21:29:27 PST

This seems to be caused by caused by r50642 ( http://trac.webkit.org/changeset/50642 ).

Comment 1 Martin Robinson 2009-11-13 22:35:55 PST

Created attachment 43222 [details]
Patch for this issue

This problem seems to be the result of a bad merge. I've attached a patch correcting the merge and extending the original insert-tab test to cover this case.

Comment 2 Gustavo Noronha (kov) 2009-11-17 10:20:39 PST

Comment on attachment 43222 [details]
Patch for this issue

> +        el.focus();
> +        if (window.eventSender) {
> +            eventSender.keyDown("\t");
> +        }

Braces.

>          if (window.layoutTestController) {
>              layoutTestController.dumpAsText();
> -            // Set this preference so the tab key will actually insert a tab character- like in Mail.
> +        }

More braces? =)

> +        if (window.layoutTestController) {
>              layoutTestController.setTabKeyCyclesThroughElements(false);
>          }

Ditto. There are some others.

Can you split the test from the translatable strings/param flags?

Comment 3 Martin Robinson 2009-11-17 11:57:15 PST

Created attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

Thanks for the review. I'm attaching corrected patches now.

Comment 4 Martin Robinson 2009-11-17 11:57:54 PST

Created attachment 43375 [details]
Properly localize tab-key-cycles-through-elements documentation strings

Comment 5 Martin Robinson 2009-11-17 12:43:04 PST

Created attachment 43378 [details]
Properly localize documentation strings (with Changelog)

Forgot the Changelog on the last patch; attaching a corrected patch now.

Comment 6 Gustavo Noronha (kov) 2009-11-18 04:40:42 PST

Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

looks good

Comment 7 Gustavo Noronha (kov) 2009-11-18 04:41:19 PST

Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)

This one as well.

Comment 8 Gustavo Noronha (kov) 2009-11-18 04:55:21 PST

Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default

I will land manually, since the bot is down.

Comment 9 Gustavo Noronha (kov) 2009-11-18 04:55:28 PST

Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)

I will land manually, since the bot is down.

Comment 10 Gustavo Noronha (kov) 2009-11-18 05:21:00 PST

Landed as r51108, and r51109.