InspectorTimelineAgent.h defines an inline function that calls a function on the document, returning the inspector... But if you try compiling webkit without inspectors, that document's function is not defined, and InspectorTimelineAgent.h thus cause a compile error. I'll upload a patch soon.
Created attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR)
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Don't forget to mark the attachment as patch. And may I interest you in the wonderful world of WebKitTools/Scripts/bugzilla-tool? (eseidel, how does you commission scheme work again?)
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) r=me.
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/abarth/git/webkit-kr/LayoutTests Testing 11625 test cases. plugins/document-open.html -> failed Exiting early after 1 failures. 9531 tests run. 498.78s total testing time 9530 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Likely a false rejection...
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: mmitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorTimelineAgent.h A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) ChangeLog looks fine to me. I suspect something is wrong with our re-born commit-queue. I'll investigate tomorrow.
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header.html -> crashed Exiting early after 1 failures. 9160 tests run. 479.50s total testing time 9159 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Bah! Looks like bug 31461 is still plaguing us. :(
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. inspector/console-dir.html -> crashed Exiting early after 1 failures. 9322 tests run. 383.17s total testing time 9321 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Sigh. Bug 31461.
Comment on attachment 43221 [details] Add a guard to compile the class only if ENABLE(INSPECTOR) Clearing flags on attachment: 43221 Committed r51136: <http://trac.webkit.org/changeset/51136>
All reviewed patches have been landed. Closing bug.