RESOLVED FIXED 31495
LayoutTests/storage/hash-change-with-xhr.html does not need the call to dumpDatabaseCallbacks() 
https://bugs.webkit.org/show_bug.cgi?id=31495
Summary LayoutTests/storage/hash-change-with-xhr.html does not need the call to dumpD...
Dumitru Daniliuc
Reported 2009-11-13 14:52:45 PST
LayoutTests/storage/hash-charge-with-xhr.html has an unnecessary call to dumpDatabaseCallbacks(). We should remove it.
Attachments
patch (1.03 KB, patch)
2009-11-13 14:53 PST, Dumitru Daniliuc 		eric: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2009-11-13 14:53:59 PST
Created attachment 43206 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-11-13 14:58:30 PST
Will this affect test results?
Eric Seidel (no email)
Comment 3 2009-11-13 14:59:51 PST
Comment on attachment 43206 [details] patch OK. I'm surprised this doesn't require results updates?
Dumitru Daniliuc
Comment 4 2009-11-13 15:01:51 PST
(In reply to comment #2) > Will this affect test results? It shouldn't. Ben said that the only reason they had that line there is to check for quota problems. However, there's no way this test is going to exceed a 5MB quota (they're only requesting 100K), so Ben agreed that this call is no longer needed. I ran all storage/ layout tests and they all passed.
Dumitru Daniliuc
Comment 5 2009-11-13 15:24:22 PST
Landed as r50969.
Note You need to log in before you can comment on or make changes to this bug.