Bug 31495 - LayoutTests/storage/hash-change-with-xhr.html does not need the call to dumpDatabaseCallbacks()
Summary: LayoutTests/storage/hash-change-with-xhr.html does not need the call to dumpD...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-13 14:52 PST by Dumitru Daniliuc
Modified: 2009-11-13 15:24 PST (History)
2 users (show)

See Also:


Attachments
patch (1.03 KB, patch)
2009-11-13 14:53 PST, Dumitru Daniliuc
eric: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2009-11-13 14:52:45 PST
LayoutTests/storage/hash-charge-with-xhr.html has an unnecessary call to dumpDatabaseCallbacks(). We should remove it.
Comment 1 Dumitru Daniliuc 2009-11-13 14:53:59 PST
Created attachment 43206 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-11-13 14:58:30 PST
Will this affect test results?
Comment 3 Eric Seidel (no email) 2009-11-13 14:59:51 PST
Comment on attachment 43206 [details]
patch

OK.  I'm surprised this doesn't require results updates?
Comment 4 Dumitru Daniliuc 2009-11-13 15:01:51 PST
(In reply to comment #2)
> Will this affect test results?

It shouldn't. Ben said that the only reason they had that line there is to check for quota problems. However, there's no way this test is going to exceed a 5MB quota (they're only requesting 100K), so Ben agreed that this call is no longer needed.

I ran all storage/ layout tests and they all passed.
Comment 5 Dumitru Daniliuc 2009-11-13 15:24:22 PST
Landed as r50969.