Bug 31491 - DOMHTMLOptionElement is missing some implementation
Summary: DOMHTMLOptionElement is missing some implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-13 14:04 PST by Jon Honeycutt
Modified: 2009-11-17 15:40 PST (History)
0 users

See Also:

Attachments
patch (2.84 KB, patch)
2009-11-13 14:16 PST, Jon Honeycutt 		mitz: review+
jhoneycutt: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2009-11-13 14:04:44 PST 
DOMHTMLOptionElement::text() and DOMHTMLOptionElement::label() are stubs.
Comment 1 Jon Honeycutt 2009-11-13 14:16:37 PST 
Created attachment 43201 [details]
patch
Comment 2 mitz 2009-11-13 15:06:26 PST 
Comment on attachment 43201 [details]
patch

> +    ASSERT(m_element && m_element->hasTagName(optionTag));

Please split into two assertions.

> +    ASSERT(m_element && m_element->hasTagName(optionTag));

Ditto.
Comment 3 Jon Honeycutt 2009-11-17 15:40:32 PST 
I made Dan's change.

Landed in r51093.