RESOLVED FIXED 31488
DOMHTMLOptionsCollection is missing some implementation 
https://bugs.webkit.org/show_bug.cgi?id=31488
Summary DOMHTMLOptionsCollection is missing some implementation
Jon Honeycutt
Reported Friday, November 13, 2009 9:53:09 PM UTC
All of the DOMHTMLOptionsCollection functions are stubs.
Attachments
patch (6.42 KB, patch)
2009-11-13 14:15 PST, Jon Honeycutt 		mitz: review+
jhoneycutt: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Honeycutt
Comment 1 Friday, November 13, 2009 10:15:03 PM UTC
Created attachment 43199 [details] patch
mitz
Comment 2 Sunday, November 15, 2009 12:20:54 AM UTC
Comment on attachment 43199 [details] patch > + if (index >= m_collection->length()) > + return E_FAIL; > + > + *result = DOMNode::createInstance(m_collection->item(index)); > + return S_OK; Can you just let HTMLOptionsCollection::item() return 0 and then null-check the result instead of bounds-checking index? It would be more like DOMHTMLCollection::item(). r=me either way
Jon Honeycutt
Comment 3 Tuesday, November 17, 2009 11:40:06 PM UTC
I made Dan's change. Landed in r51091.
Note You need to log in before you can comment on or make changes to this bug.