Bug 314819 – [GTK][WPE][Tools] layout tests are failing when using the auto-enter WebKit Container SDK environment

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Alberto Lopez Perez]

Layout tests fail to run with the new auto-enter-into-sdk-container feature:

06:59:47.390 183 Starting HTTP server ...
06:59:47.391 183 Running "/usr/sbin/apache2 -v"...
06:59:47.407 183 "/usr/sbin/apache2 -v" took 0.02s.
06:59:47.407 183 Running "/usr/sbin/apache2 -v"...
06:59:47.421 183 "/usr/sbin/apache2 -v" took 0.01s.
06:59:47.423 183 Starting httpd server, cmd="['/usr/sbin/apache2', '-f', '/sdk/webkit/layout-test-results/httpd.conf', '-C', 'DocumentRoot "/sdk/webkit/LayoutTests/http/tests"', '-c', 'TypesConfig "/sdk/webkit/LayoutTests/http/conf/mime.types"', '-c', 'CustomLog "/sdk/webkit/layout-test-results/access_log.txt" common', '-c', 'ErrorLog "/sdk/webkit/layout-test-results/error_log.txt"', '-c', 'PidFile "/tmp/WebKit/httpd.pid"', '-k', 'start', '-c', 'Alias /ipc/coreipc.js "/sdk/webkit/LayoutTests/ipc/coreipc.js"', '-c', 'Alias /js-test-resources "/sdk/webkit/LayoutTests/resources"', '-c', 'Alias /media-resources "/sdk/webkit/LayoutTests/media"', '-c', 'Alias /modern-media-controls "/sdk/webkit/LayoutTests/../Source/WebCore/Modules/modern-media-controls"', '-c', 'Alias /resources/testharness.css "/sdk/webkit/LayoutTests/resources/testharness.css"', '-c', 'Alias /resources/testharness.js "/sdk/webkit/LayoutTests/resources/testharness.js"', '-c', 'Alias /resources/testharnessreport.js "/sdk/webkit/LayoutTests/resources/testharnessreport.js"', '-c', 'Alias /root "/sdk/webkit/LayoutTests/."', '-C', 'User ""', '-C', 'Listen 127.0.0.1:8000', '-C', 'Listen [::1]:8000', '-C', 'Listen 127.0.0.1:8080', '-C', 'Listen [::1]:8080', '-C', 'Listen 127.0.0.1:8443', '-C', 'Listen [::1]:8443', '-c', 'SSLCertificateFile "/sdk/webkit/LayoutTests/http/conf/webkit-httpd.pem"']"

ServerError raised: Failed to start httpd: b'AH00526: Syntax error on line 2 of -c/-C directives:\nUser takes one argument, Effective user id for this server\n' (exit code=1)
Traceback (most recent call last):
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 102, in main
    run_details = run(port, options, args, stderr)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 573, in run
    run_details = manager.run(args)
                  ^^^^^^^^^^^^^^^^^
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 452, in run
    self._runner = LayoutTestRunner(self._options, self._port, self._printer, self._results_directory,
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 124, in __init__
    self.start_servers()
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 293, in start_servers
    self._port.start_http_server(self._additional_dirs_for_http_server())
  File "/sdk/webkit/Tools/Scripts/webkitpy/port/base.py", line 875, in start_http_server
    server.start()
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py", line 98, in start
    self._pid = self._spawn_process()
                ^^^^^^^^^^^^^^^^^^^^^
  File "/sdk/webkit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py", line 207, in _spawn_process
    raise self._server_error('Failed to start %s' % self._name, err, retval)
webkitpy.layout_tests.servers.http_server_base.ServerError: Failed to start httpd: b'AH00526: Syntax error on line 2 of -c/-C directives:\nUser takes one argument, Effective user id for this server\n' (exit code=1)


The issue is that it fails to start the http server because it is passing '-C', 'User ""' instead of  '-C', 'User "buildbot-worker"'

And that is because the tooling resolves the user from the environment:
Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:            start_cmd.extend(['-C', 'User "%s"' % os.environ.get("USERNAME", os.environ.get("USER", ""))])

And we are not forwarding the env variables USER or USERNAME into the sdk container env

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/64933

[EWS]

Committed 313242@main (e9ddfb6d1b2b): <https://commits.webkit.org/313242@main>

Reviewed commits have been landed. Closing PR #64933 and removing active labels.