Bug 31471 - Web Inspector: Refactor timeline tests so that they do not require reload
Summary: Web Inspector: Refactor timeline tests so that they do not require reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Ayers
URL:
Keywords:
Depends on:
Blocks: 31472
  Show dependency tree / graph
 
Reported: 2009-11-13 06:30 PST by Pavel Feldman
Modified: 2009-11-29 12:54 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-13 06:30:18 PST 
I am about to modify testing framework so that inspector is shown by the DRT rather than test itself. It'll make us faster, more robust and allow more reliable cleanup after the test. Timeline tests are the only ones that do not work with the new setup. Two ways of fixing:
1) After installing custom handler for addRecord, do something on page in order to get some timeline records
2) Do not install custom handler, go through the WebInspector.panels.timeline._items array instead. Note that it contains 'formatted' records, not the original ones that came from the backend. However, it is easy to modify the TimelinePanel and make formatted record point to the original one. I like (2) more.
Comment 1 Pavel Feldman 2009-11-29 12:54:46 PST 
This has been landed in patches from other bugs.