WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31471
Web Inspector: Refactor timeline tests so that they do not require reload
https://bugs.webkit.org/show_bug.cgi?id=31471
Summary
Web Inspector: Refactor timeline tests so that they do not require reload
Pavel Feldman
Reported
2009-11-13 06:30:18 PST
I am about to modify testing framework so that inspector is shown by the DRT rather than test itself. It'll make us faster, more robust and allow more reliable cleanup after the test. Timeline tests are the only ones that do not work with the new setup. Two ways of fixing: 1) After installing custom handler for addRecord, do something on page in order to get some timeline records 2) Do not install custom handler, go through the WebInspector.panels.timeline._items array instead. Note that it contains 'formatted' records, not the original ones that came from the backend. However, it is easy to modify the TimelinePanel and make formatted record point to the original one. I like (2) more.
Attachments
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2009-11-29 12:54:46 PST
This has been landed in patches from other bugs.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug