WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
314676
[check-webkit-style] Flag deprecated js-test-pre/post/post-async.js includes
https://bugs.webkit.org/show_bug.cgi?id=314676
Summary
[check-webkit-style] Flag deprecated js-test-pre/post/post-async.js includes
zak ridouh
Reported
2026-05-12 16:02:06 PDT
New tests should use LayoutTests/resources/js-test.js, which combines the functionality of the old trio. For async tests, set window.jsTestIsAsync = true and call finishJSTest() when done. - Adds DeprecatedJSTestIncludesChecker, composed into TextChecker, with unit tests. Category build/deprecated/js-test-helpers, severity 5. - Adds a // DEPRECATED: banner to the six resource files pointing authors at js-test.js. The LayoutTests/resources/ and http/tests/resources/ pairs remain byte-identical as JSTestChecker requires.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-05-12 16:02:12 PDT
<
rdar://problem/176924986
>
zak ridouh
Comment 2
2026-05-12 16:03:37 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/64791
EWS
Comment 3
2026-05-13 16:24:59 PDT
Committed
313204@main
(ea89893f4a43): <
https://commits.webkit.org/313204@main
> Reviewed commits have been landed. Closing PR #64791 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug