Bug 31459 - WebCore::externalRepresentation should update layout before getting render object
Summary: WebCore::externalRepresentation should update layout before getting render ob...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 23:49 PST by Shinichiro Hamaji
Modified: 2009-11-13 16:07 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (2.75 KB, patch)
2009-11-12 23:52 PST, Shinichiro Hamaji 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-11-12 23:49:59 PST 
This refactoring is suggested in Bug 30555 and Bug 31393.
Comment 1 Shinichiro Hamaji 2009-11-12 23:52:52 PST 
Created attachment 43140 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2009-11-12 23:55:13 PST 
Actually, this change seems to fix the wrong test expectation for svg/custom/gradient-stop-style-change-expected . Though I don't know about this test at all, it seems the expectation becomes better (the color was originally #FF0000 (red) and now it is #008000 (green)).
Comment 3 Darin Adler 2009-11-13 08:42:39 PST 
Comment on attachment 43140 [details]
Patch v1

r=me
Comment 4 Shinichiro Hamaji 2009-11-13 16:07:23 PST 
Comment on attachment 43140 [details]
Patch v1

Clearing flags on attachment: 43140

Committed r50976: <http://trac.webkit.org/changeset/50976>
Comment 5 Shinichiro Hamaji 2009-11-13 16:07:31 PST 
All reviewed patches have been landed.  Closing bug.