WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31452
Fix worker-timeout.html layout test that fails in Chromium harness.
https://bugs.webkit.org/show_bug.cgi?id=31452
Summary
Fix worker-timeout.html layout test that fails in Chromium harness.
Dmitry Titov
Reported
2009-11-12 19:09:13 PST
In DRT, the layoutTestController.notifyDone() captures the output immediately. In Chromium, the test_shell does the same. However, some layout tests (those that require multiprocess config) are running in ui_test Chromium harness that runs the full Chromium browser and uses different implementation of layoutTestController. In that one, the notifyDone() runs message loop for a while before capturing the output. This causes worker-timeout test to squeeze more lines into the log then expected. This is Chromium bug
http://crbug.com/25548
The test keeps active interval firing while terminating, to verify that this doesn't cause a crash (it did at some point). So lets keep the interval firing but stop logging once notifyDone() is called. Patch forthcoming.
Attachments
Proposed patch.
(2.21 KB, patch)
2009-11-12 19:22 PST
,
Dmitry Titov
darin
: review+
dimich
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dmitry Titov
Comment 1
2009-11-12 19:22:21 PST
Created
attachment 43128
[details]
Proposed patch.
Dmitry Titov
Comment 2
2009-11-13 10:08:13 PST
Landed:
http://trac.webkit.org/changeset/50950
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug