Bug 31452 - Fix worker-timeout.html layout test that fails in Chromium harness.
Summary: Fix worker-timeout.html layout test that fails in Chromium harness.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dmitry Titov
Depends on:
Reported: 2009-11-12 19:09 PST by Dmitry Titov
Modified: 2009-11-13 10:08 PST (History)
1 user (show)

See Also:

Proposed patch. (2.21 KB, patch)
2009-11-12 19:22 PST, Dmitry Titov
darin: review+
dimich: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-11-12 19:09:13 PST
In DRT, the layoutTestController.notifyDone() captures the output immediately. In Chromium, the test_shell does the same. However, some layout tests (those that require multiprocess config) are running in ui_test Chromium harness that runs the full Chromium browser and uses different implementation of layoutTestController. In that one, the notifyDone() runs message loop for a while before capturing the output. This causes worker-timeout test to squeeze more lines into the log then expected. This is Chromium bug http://crbug.com/25548

The test keeps active interval firing while terminating, to verify that this doesn't cause a crash (it did at some point). So lets keep the interval firing but stop logging once notifyDone() is called. Patch forthcoming.
Comment 1 Dmitry Titov 2009-11-12 19:22:21 PST
Created attachment 43128 [details]
Proposed patch.
Comment 2 Dmitry Titov 2009-11-13 10:08:13 PST
Landed: http://trac.webkit.org/changeset/50950