Bug 31443 - [V8] De-inline simple get/set methods completely, and optimize error handling
Summary: [V8] De-inline simple get/set methods completely, and optimize error handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Enhancement
Assignee: Jens Alfke
URL:
Keywords:
Depends on:
Blocks: 31217
  Show dependency treegraph
 
Reported: 2009-11-12 15:42 PST by Jens Alfke
Modified: 2009-11-12 16:24 PST (History)
0 users

See Also:


Attachments
patch (8.36 KB, patch)
2009-11-12 16:05 PST, Jens Alfke
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Alfke 2009-11-12 15:42:25 PST
Getters and setter methods on Element classes that return strings can be optimized into a single function call that just takes the V8 parameters and the QualifiedName of the attribute (and the new value, for the setter.)
I've also thrown in a small optimization to the event handling that avoids multiple calls to V8Proxy::setDOMException in a single method.
Comment 1 Jens Alfke 2009-11-12 16:05:15 PST
Created attachment 43112 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-11-12 16:07:03 PST
Comment on attachment 43112 [details]
patch

sounds good.
Comment 3 Jens Alfke 2009-11-12 16:24:01 PST
Committed revision 50914.