Bug 31439 - Web Inspector: preload status bar button glyphs in order to prevent them from flickering.
Summary: Web Inspector: preload status bar button glyphs in order to prevent them from...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 14:17 PST by Pavel Feldman
Modified: 2009-11-13 09:27 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] proposed fix (2.23 KB, patch)
2009-11-12 14:19 PST, Pavel Feldman
timothy: review-
Details | Formatted Diff | Diff
[PATCH] addressed comments (1.85 KB, patch)
2009-11-12 15:00 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-12 14:17:27 PST
I am going to put them into inspector.html.
Comment 1 Pavel Feldman 2009-11-12 14:19:17 PST
Created attachment 43098 [details]
[PATCH] proposed fix
Comment 2 Timothy Hatcher 2009-11-12 14:46:36 PST
Comment on attachment 43098 [details]
[PATCH] proposed fix

I prefer preloading from JS doing:

(new Image()).src = "Images/clearConsoleButtonGlyph.png";

That way the DOM isn't involved and polluted.
Comment 3 Pavel Feldman 2009-11-12 15:00:22 PST
Created attachment 43104 [details]
[PATCH] addressed comments
Comment 4 Pavel Feldman 2009-11-12 15:04:35 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r50908
Comment 5 Pavel Feldman 2009-11-13 02:46:11 PST
I had to revert this due to tests timing out. Need to find a way of telling frontend that it is within tests, that way it would be able to skip this step.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r50935
Comment 6 Timothy Hatcher 2009-11-13 09:21:43 PST
How did this cause a timeout?
Comment 7 Pavel Feldman 2009-11-13 09:27:12 PST
(In reply to comment #6)
> How did this cause a timeout?

I am not sure, I noticed Tiger being flaky after that commit. It did not stop being so after I rolled back though. So re-applying.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r50947