Bug 31426 - Some WebSocket tests don't properly listen to close event
Summary: Some WebSocket tests don't properly listen to close event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 11:43 PST by Alexey Proskuryakov
Modified: 2009-11-12 12:17 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (6.34 KB, patch)
2009-11-12 11:48 PST, Alexey Proskuryakov
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-11-12 11:43:50 PST
It should be "ws.onclose", not "ws.close".

As a result, tests take longer (there are 2 or 3 second timers meant to make them end), and lack some of the output.
Comment 1 Alexey Proskuryakov 2009-11-12 11:48:31 PST
Created attachment 43085 [details]
proposed patch
Comment 2 David Levin 2009-11-12 11:56:37 PST
Comment on attachment 43085 [details]
proposed patch

Thanks.
Comment 3 Alexey Proskuryakov 2009-11-12 12:17:17 PST
Committed r50892.