RESOLVED FIXED 31418
Chrome/mac does not send keypress() for keys with cmd down 
https://bugs.webkit.org/show_bug.cgi?id=31418
Summary Chrome/mac does not send keypress() for keys with cmd down
Nico Weber
Reported 2009-11-12 10:16:17 PST
I regressed this by being overzealous in http://codereview.chromium.org/378019 . Fix.
Attachments
Patch. (1.89 KB, patch)
2009-11-12 10:16 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2009-11-12 10:16:56 PST
Created attachment 43073 [details] Patch.
Dimitri Glazkov (Google)
Comment 2 2009-11-12 10:19:57 PST
Comment on attachment 43073 [details] Patch. Can we write a layout test for this?
Nico Weber
Comment 3 2009-11-12 10:23:58 PST
Not really, as the interesting thing here is the interaction with webkit and chrome. There's a bug to add more system-test like tests for keyboard handling for chrome/mac, but it's blocked on getting interactive browser tests running on os x. I have a list of stuff that I want to convert to tests at the bottom of http://sites.google.com/a/chromium.org/dev/developers/os-x-keyboard-handling , and will do so once the interactive tests work.
Nico Weber
Comment 4 2009-11-12 10:32:20 PST
and by "interaction with" I mean "interaction between".
Dimitri Glazkov (Google)
Comment 5 2009-11-12 10:36:23 PST
Comment on attachment 43073 [details] Patch. ok.
WebKit Commit Bot
Comment 6 2009-11-12 10:46:28 PST
Comment on attachment 43073 [details] Patch. Clearing flags on attachment: 43073 Committed r50887: <http://trac.webkit.org/changeset/50887>
WebKit Commit Bot
Comment 7 2009-11-12 10:46:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.