WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
314166
[submitproject] Use includes rather than excludes
https://bugs.webkit.org/show_bug.cgi?id=314166
Summary
[submitproject] Use includes rather than excludes
Jonathan Bedard
Reported
2026-05-05 21:17:25 PDT
Excludes can easily be accidentally over-inclusive. We should use includes rather than excludes in our .submitproject. Excludes also cannot be overriden by all .submitproject processing systems, so excluding a directory prevents future expansions from including the same directory.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-05-05 21:17:32 PDT
<
rdar://problem/176326251
>
Jonathan Bedard
Comment 2
2026-05-05 21:19:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/64336
EWS
Comment 3
2026-05-18 07:45:49 PDT
Committed
313414@main
(1a68aba71cc9): <
https://commits.webkit.org/313414@main
> Reviewed commits have been landed. Closing PR #64336 and removing active labels.
EWS
Comment 4
2026-05-18 16:46:08 PDT
Committed
305413.926@safari-7624-branch
(bce6efe324df): <
https://commits.webkit.org/305413.926@safari-7624-branch
> Reviewed commits have been landed. Closing PR #5306 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug