RESOLVED FIXED 31414
Replace worldIDs with world objects 
https://bugs.webkit.org/show_bug.cgi?id=31414
Summary Replace worldIDs with world objects
Adam Roben (:aroben)
Reported 2009-11-12 08:30:15 PST
In discussions with Sam Weinig, Dave Hyatt, and John Sullivan, I've come up with a new SPI for dealing with user scripts and stylesheets and isolated worlds. This bug covers implementing this SPI.
Attachments
Small clean-up in WebView's user content functions (6.39 KB, patch)
2009-11-12 08:31 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Remove worldIDs from WebKit's SPI (77.98 KB, patch)
2009-11-12 11:33 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Finish replacing worldIDs with world objects (13.07 KB, patch)
2009-11-13 08:54 PST, Adam Roben (:aroben) 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-11-12 08:31:32 PST
Created attachment 43066 [details] Small clean-up in WebView's user content functions
Dave Hyatt
Comment 2 2009-11-12 10:23:00 PST
Comment on attachment 43066 [details] Small clean-up in WebView's user content functions r=me
Adam Roben (:aroben)
Comment 3 2009-11-12 11:33:05 PST
Created attachment 43084 [details] Remove worldIDs from WebKit's SPI
Timothy Hatcher
Comment 4 2009-11-12 12:13:01 PST
Comment on attachment 43084 [details] Remove worldIDs from WebKit's SPI I don't have time to do a full review. But WebJSWorld is hard to read. This would have been better named WebScriptWorld. (To match WebScriptObject.)
Timothy Hatcher
Comment 5 2009-11-12 12:15:00 PST
Comment on attachment 43084 [details] Remove worldIDs from WebKit's SPI collectionWithWorld should be collectionWithScriptWorld if you take my WebScriptWorld suggestion. Same with initWithWorld.
Timothy Hatcher
Comment 6 2009-11-12 12:16:08 PST
- (JSGlobalContextRef)globalContextInWorld:(WebJSWorld *)world; reads better as: - (JSGlobalContextRef)globalContextForScriptWorld:(WebScriptWorld *)world;
Adam Roben (:aroben)
Comment 7 2009-11-12 14:35:22 PST
Thanks for the reviews, Sam and Hyatt! I'm going to make Tim's suggested renames and then land these two patches.
Adam Roben (:aroben)
Comment 8 2009-11-12 14:41:34 PST
Comment on attachment 43066 [details] Small clean-up in WebView's user content functions Landed in r50906 <http://trac.webkit.org/changeset/50906>
Adam Roben (:aroben)
Comment 9 2009-11-12 14:41:47 PST
Comment on attachment 43084 [details] Remove worldIDs from WebKit's SPI Landed in r50907 <http://trac.webkit.org/changeset/50907>
Adam Roben (:aroben)
Comment 10 2009-11-12 15:45:15 PST
This doesn't block bug 31124 anymore, now that the patch in attachment 43084 [details] has landed.
Adam Barth
Comment 11 2009-11-12 18:40:49 PST
These patches claim to have been landed.
Adam Roben (:aroben)
Comment 12 2009-11-12 20:40:12 PST
Yes, but there are more coming (eventually).
Adam Barth
Comment 13 2009-11-12 21:41:46 PST
Why not use one patch per bug? It's hard to follow these bugs once they go epic.
Adam Barth
Comment 14 2009-11-12 21:42:03 PST
Comment on attachment 43084 [details] Remove worldIDs from WebKit's SPI Remove from pending-commit.
Adam Roben (:aroben)
Comment 15 2009-11-13 07:40:34 PST
(In reply to comment #13) > Why not use one patch per bug? It's hard to follow these bugs once they go > epic. OK, I'll do that.
Adam Roben (:aroben)
Comment 16 2009-11-13 07:57:27 PST
OK, I have one more teeny patch that really does belong in this bug. But then I'll move to a new one, I promise!
Adam Roben (:aroben)
Comment 17 2009-11-13 08:54:35 PST
Created attachment 43162 [details] Finish replacing worldIDs with world objects
Mark Rowe (bdash)
Comment 18 2009-11-13 08:56:00 PST
Comment on attachment 43162 [details] Finish replacing worldIDs with world objects r=me
Adam Roben (:aroben)
Comment 19 2009-11-13 08:59:35 PST
Committed r50943: <http://trac.webkit.org/changeset/50943>
Note You need to log in before you can comment on or make changes to this bug.